Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error should be handled properly in redo Manager #6368

Closed
CharlesCheung96 opened this issue Jul 20, 2022 · 0 comments · Fixed by #6366
Closed

error should be handled properly in redo Manager #6368

CharlesCheung96 opened this issue Jul 20, 2022 · 0 comments · Fixed by #6366
Labels
affects-6.1 area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.

Comments

@CharlesCheung96
Copy link
Contributor

CharlesCheung96 commented Jul 20, 2022 •
edited
Loading

What did you expect to see?

redoManager should return errors to the caller via errCh

What did you see instead?

The caller(In processor) did not receive error.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
@CharlesCheung96 CharlesCheung96 added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Jul 20, 2022
@CharlesCheung96 CharlesCheung96 mentioned this issue Jul 20, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jul 21, 2022
@CharlesCheung96
redo(ticdc): handle error correctly in redo manager (#6366)
c2bb3d8 
close #6368
@ti-chi-bot ti-chi-bot mentioned this issue Jul 21, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jul 21, 2022
@ti-chi-bot
redo(ticdc): handle error correctly in redo manager (#6366) (#6386)
7ae9dca 
close #6368
@ti-chi-bot ti-chi-bot mentioned this issue Jul 21, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jul 21, 2022
@ti-chi-bot
redo(ticdc): handle error correctly in redo manager (#6366) (#6386) (#…
052c6e7 
…6414)

close #6368
This was referenced Aug 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redo(ticdc): handle error correctly in redo manager CharlesCheung96/tiflow
2 participants
@CharlesCheung96 @ti-chi-bot