Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More enhancements are needed for redolog file/dir handling #6380

Closed
zhaoxinyu opened this issue Jul 20, 2022 · 4 comments · Fixed by #6363
Closed

More enhancements are needed for redolog file/dir handling #6380

zhaoxinyu opened this issue Jul 20, 2022 · 4 comments · Fixed by #6363
Labels
area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.

Comments

@zhaoxinyu
Copy link
Contributor

  1. Redolog dir should be created before writing to file
  2. Redo meta/ddl/row files should be renamed from a temp file atomically.
@zhaoxinyu
Copy link
Contributor Author

/type enhancement

@ti-chi-bot ti-chi-bot added the type/enhancement The issue or PR belongs to an enhancement. label Jul 20, 2022
@zhaoxinyu zhaoxinyu mentioned this issue Jul 20, 2022
Merged
@zhaoxinyu
Copy link
Contributor Author

/area cdc

@ti-chi-bot
Copy link
Member

@zhaoxinyu: The label(s) area/cdc cannot be applied, because the repository doesn't have them.

In response to this:

/area cdc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhaoxinyu
Copy link
Contributor Author

/area ticdc

@ti-chi-bot ti-chi-bot added the area/ticdc Issues or PRs related to TiCDC. label Jul 21, 2022
@zhaoxinyu zhaoxinyu changed the title Redolog need more enhancements for file/dir handling More enhancements are needed for redolog file/dir handling Jul 21, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 21, 2022
@zhaoxinyu
redo(ticdc): Pre-create redolog dir before file allocation (#6363)
97f6592 
close #6380
@ti-chi-bot ti-chi-bot mentioned this issue Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redo(ticdc): Pre-create redolog dir before file allocation zhaoxinyu/ticdc
2 participants
@zhaoxinyu @ti-chi-bot