Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build up a black list for unnecessary retry MySQL Error. #8087

Closed
asddongmen opened this issue Jan 17, 2023 · 1 comment · Fixed by #8088
Closed

Build up a black list for unnecessary retry MySQL Error. #8087

asddongmen opened this issue Jan 17, 2023 · 1 comment · Fixed by #8088
Assignees
@asddongmen
Labels
affects-6.1 affects-6.5 area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@asddongmen
Copy link
Contributor

asddongmen commented Jan 17, 2023 •
edited
Loading

Is your feature request related to a problem?

We should not try to execute DML or DDL statements repeatedly when encountering certain types of errors, such as
:[ErrPartitionMgmtOnNonpartitioned].

To avoid spending a lot of time on retries, a blacklist is needed to contain this type of error.

Since it is impossible to find all errors that should not be retried at once, this issue should be open for a long time, and we should keep updating this blacklist.

Describe the feature you'd like

as above.

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@asddongmen asddongmen added area/ticdc Issues or PRs related to TiCDC. type/feature Issues about a new feature labels Jan 17, 2023
@asddongmen asddongmen self-assigned this Jan 17, 2023
This was referenced Jan 17, 2023
Merged
Merged
@nongfushanquan
Copy link
Contributor

/label affects-6.1

@asddongmen asddongmen added type/bug The issue is confirmed as a bug. affects-6.5 and removed type/feature Issues about a new feature labels Jan 17, 2023
ti-chi-bot pushed a commit that referenced this issue Jan 17, 2023
@asddongmen
error,sink (ticdc): add mysql error black list (#8090)
34aaa8b 
ref #8087
@nongfushanquan nongfushanquan mentioned this issue Feb 24, 2023
Merged
15 tasks
ti-chi-bot pushed a commit that referenced this issue Feb 28, 2023
@asddongmen
sink(ticdc): add one errors to ddl unretryable black list. (#8088)
a14273a 
close #8087
This was referenced Feb 28, 2023
Closed
Merged
ti-chi-bot added a commit that referenced this issue Feb 28, 2023
@ti-chi-bot
sink(ticdc): add one errors to ddl unretryable black list. (#8088) (#…
db2e700 
…8389)

close #8087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asddongmen asddongmen

Labels
affects-6.1 affects-6.5 area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sink(ticdc): add one errors to ddl unretryable black list. asddongmen/tiflow
3 participants
@asddongmen @ti-chi-bot @nongfushanquan