Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink/mysql: fix statistics print status missing in MySQL sink #1023

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

If replication normally with mysql sink, there could be no log for a long time, which is curious.

What is changed and how it works?

Add periodic statistics status log in MySQL sink

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added the needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. label Oct 23, 2020
@amyangfei amyangfei added this to the v4.0.8 milestone Oct 23, 2020
@amyangfei amyangfei added the status/ptal Could you please take a look? label Oct 23, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 23, 2020
@amyangfei
Copy link
Contributor Author

/run-all-tests

@liuzix
Copy link
Contributor

liuzix commented Oct 23, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 23, 2020
@liuzix liuzix merged commit 015acb8 into pingcap:master Oct 23, 2020
@amyangfei amyangfei deleted the mysql-sink-statistics branch October 23, 2020 05:46
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Oct 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants