-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TiCDC support checking if data is entirely replicated to Downstream (#10133) #10340
TiCDC support checking if data is entirely replicated to Downstream (#10133) #10340
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/test verify |
/retest |
6b25733
to
9d01e29
Compare
9d01e29
to
500360b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test verify |
/test pull-cdc-integration-mysql-test |
@hongyunyan: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test cdc-integration-mysql-test |
1 similar comment
/test cdc-integration-mysql-test |
This is an automated cherry-pick of #10133
What problem does this PR solve?
Issue Number: close #10289
What is changed and how it works?
lastSyncedTs
to record the latest commitTs received by sink modulelastSyncedTs
from tables and do aggregate at changefeed level to obtain a changefeed levellastSyncedTs
api/v2/changefeeds/<changefeed-id>/synced
to get the changefeed synced status.Check List
Tests
Unit test
Integration test
For integration test, I add the test for both normal cases and failure cases, such as tikv failed etc.
Manual test (add detailed scripts or steps below)
The http api looks like it:
For performance test, we do pressure test on master and ours cdc and get the same sink output, which shows the PR have no impact on the performance.
No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note