Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/filter(ticdc): ignore ddl in ddl_manager (#10518) #10540

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10518

What problem does this PR solve?

Issue Number: close #10524

What is changed and how it works?

ignore ddl in ddl_manager, and the behavior of TiCDC in ignoring create/delete/truncate/alter DDL scenarios is as follows:

  1. After a table or partition is created, TiCDC synchronizes the new physical table.
  2. After a table or partition is dropped, TiCDC does not synchronize the deleted physical table.
  3. After a table or partition is truncated, TiCDC does not synchronize the deleted physical table, and synchronizes the new physical table.
  4. After the Alter table or partition ddl, CDC still uses the schma of the new table to parse data.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Fix the issue of cdc does not synchronize related tables after ddl was filtered`.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 24, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2024
Copy link
Contributor

@asddongmen asddongmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@CharlesCheung96
Copy link
Contributor

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor

/retest

Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 84c2df7 into pingcap:release-7.1 Jan 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants