Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc : Split sync_status test to reduce integration ci time #10700

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

hongyunyan
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #10457

What is changed and how it works?

Split sync_status test to reduce integration ci time

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #10700 (b9cac5d) into master (31dd24f) will increase coverage by 0.0125%.
The diff coverage is n/a.

Additional details and impacted files
Components Coverage Δ
cdc ∅ <ø> (∅)
dm 51.1970% <ø> (+0.0262%) ⬆️
engine 63.3743% <ø> (-0.0354%) ⬇️
Flag Coverage Δ
unit 53.9048% <ø> (+0.0125%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10700        +/-   ##
================================================
+ Coverage   53.8923%   53.9048%   +0.0125%     
================================================
  Files           403        403                
  Lines         63651      63651                
================================================
+ Hits          34303      34311         +8     
+ Misses        26642      26636         -6     
+ Partials       2706       2704         -2     

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-04 06:48:30.654785048 +0000 UTC m=+63337.677031437: ☑️ agreed by asddongmen.
  • 2024-03-04 06:48:55.516561786 +0000 UTC m=+63362.538808175: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot bot merged commit 5311baa into pingcap:master Mar 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants