Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter(ticdc): default value convert to the correct data type #10804

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Mar 18, 2024

What problem does this PR solve?

Issue Number: close #10803

What is changed and how it works?

  • convert the datum to the specific column type

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

fix the default value is always string type since not considering data type causes the open-protocol output incorrect type value

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #10804 (32a8192) into master (12a184e) will increase coverage by 0.0406%.
Report is 5 commits behind head on master.
The diff coverage is 70.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 61.9036% <70.0000%> (+0.0071%) ⬆️
dm 51.2899% <ø> (+0.0686%) ⬆️
engine 63.4430% <ø> (+0.0706%) ⬆️
Flag Coverage Δ
unit 57.5891% <70.0000%> (+0.0406%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10804        +/-   ##
================================================
+ Coverage   57.5485%   57.5891%   +0.0406%     
================================================
  Files           853        853                
  Lines        126886     126958        +72     
================================================
+ Hits          73021      73114        +93     
+ Misses        48427      48411        -16     
+ Partials       5438       5433         -5     

@3AceShowHand
Copy link
Contributor Author

/retest

Copy link
Collaborator

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 01:53:11.787152077 +0000 UTC m=+1428018.809398457: ☑️ agreed by hongyunyan.
  • 2024-03-20 06:55:53.748559221 +0000 UTC m=+1446180.770805609: ☑️ agreed by CharlesCheung96.

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. label Mar 20, 2024
@3AceShowHand 3AceShowHand added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 99b3eb4 into pingcap:master Mar 20, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #10826.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10827.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10828.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10829.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 3, 2024
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Apr 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiCDC fill the default value without consider the real data type
4 participants