kafka_consumer: fix wrong timezone when 'TZ' env is not set and downstream is mysql #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
added
the
first-time-contributor
|
Thanks for your contribution! The CI failure is related to https://github.com/pingcap/ticdc/pull/1087, it has nothing to do with this PR |
|
/run-kafka-tests |
amyangfei
added
type/bugfix
zier-one
approved these changes
Nov 18, 2020
ti-srebot
approved these changes
Nov 18, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@dengqee merge failed. |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Nov 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1095 |
amyangfei
pushed a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka_consumer: fix wrong timezone when 'TZ' env is not set and downstream is mysql
Improve robustness.
What problem does this PR solve?
*: fix wrong timezone when env
TZis not set #512 fix wrong timezone in cdc, but kafka_consumer demo still have this problem, see kafka_consumer wrong timezone when no parameter ‘--timezone’ and env ‘TZ’ is not set #1082.What is changed and how it works?
This pr load local timezone by calling util.GetTimezone instead of use time.Local
Check List
Tests
Code changes
Has exported function/method change
Related changes
Need to cherry-pick to the release branch
Release note
kafka_consumer: fix wrong timezone when 'TZ' env is not set and downstream is mysql