processor(ticdc): Fix processor panic issue #10922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
release-note-none
sdojjy
changed the title
ti-chi-bot
bot
added
the
size/S
asddongmen
approved these changes
Apr 18, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
3AceShowHand
approved these changes
Apr 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10922 +/- ##
================================================
+ Coverage 57.3986% 57.4272% +0.0285%
================================================
Files 850 850
Lines 125137 125141 +4
================================================
+ Hits 71827 71865 +38
+ Misses 47914 47883 -31
+ Partials 5396 5393 -3 |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
|
/retest-required |
sdojjy
added a commit
to sdojjy/tiflow
that referenced
this pull request
Apr 24, 2024
sdojjy
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10921
What is changed and how it works?
If a processor is not initialized and then call writerDebugInfo command, ticdc will panic because of tableManager is nil
this PR will check if the processor is initialized or not, if not initialized, then print a log, false add a ut case to cover it.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note