processor(ticdc): Initialize the processor before tick it #10928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10928 +/- ##
================================================
+ Coverage 57.4176% 57.4771% +0.0594%
================================================
Files 850 851 +1
Lines 125141 125269 +128
================================================
+ Hits 71853 72001 +148
+ Misses 47891 47884 -7
+ Partials 5397 5384 -13 |
|
/retest |
ti-chi-bot
bot
added
size/M
|
/retest-required |
1 similar comment
|
/retest-required |
3AceShowHand
approved these changes
Apr 19, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
This reverts commit c8ed99f.
ti-chi-bot
bot
added
size/XL
asddongmen
changed the title
|
/test cdc-integration-kafka-test |
|
/retest-required |
ti-chi-bot
bot
added
size/M
asddongmen
approved these changes
Apr 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest-required |
1 similar comment
|
/retest-required |
sdojjy
added a commit
to sdojjy/tiflow
that referenced
this pull request
Apr 24, 2024
) close pingcap#10930 # Conflicts: # cdc/processor/processor.go
sdojjy
added a commit
to sdojjy/tiflow
that referenced
this pull request
Apr 24, 2024
) close pingcap#10930 # Conflicts: # cdc/processor/processor.go
sdojjy
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10930
What is changed and how it works?
This PR initiates the processor before ticking it.
These changes can also prevent some data races that occur during processor initialization.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note