Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec(ticdc): simple decoder set column flag incorrectly since miss index id #11235

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Jun 4, 2024

What problem does this PR solve?

Issue Number: close #11236

What is changed and how it works?

  • set index id to distinguish each index

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 04:07:13.991165822 +0000 UTC m=+3354187.748301390: ☑️ agreed by asddongmen.
  • 2024-06-04 04:12:29.028581973 +0000 UTC m=+3354502.785717538: ☑️ agreed by lidezhu.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.6838%. Comparing base (70e4d6e) to head (7dd9454).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.5142% <100.0000%> (+0.0615%) ⬆️
dm 51.2384% <ø> (+0.0483%) ⬆️
engine 63.4232% <ø> (+0.0141%) ⬆️
Flag Coverage Δ
unit 57.6838% <100.0000%> (+0.0512%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11235        +/-   ##
================================================
+ Coverage   57.6326%   57.6838%   +0.0512%     
================================================
  Files           850        850                
  Lines        126050     126056         +6     
================================================
+ Hits          72646      72714        +68     
+ Misses        48001      47951        -50     
+ Partials       5403       5391        -12     

@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@3AceShowHand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test 7dd9454 link unknown /test cdc-integration-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 667cea0 into pingcap:master Jun 4, 2024
25 of 28 checks passed
3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 4, 2024
@3AceShowHand
Copy link
Contributor Author

This is cherry-pick back to release-7.5 by the #11228

@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jun 4, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple protocol decoder set index column incorrectly
4 participants