Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: change the calculation of first sync point ts #11253

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Jun 5, 2024

What problem does this PR solve?

Issue Number: close #11212

What is changed and how it works?

In this PR, we change the calculation of the first sync point ts.
As before, we use startTs as the first sync point ts.
Afer the PR, the first-sync-point-ts = k * sync-point-ts-interval,
and we will choose the minimal k that satisfy the first-sync-point-ts >= startTs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Change the calculation of first sync point ts.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2024
@hongyunyan
Copy link
Collaborator Author

/retest

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.6391%. Comparing base (667cea0) to head (cf76a07).
Report is 9 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.4440% <100.0000%> (-0.0670%) ⬇️
dm 51.2111% <ø> (+0.0100%) ⬆️
engine 63.3879% <ø> (-0.0142%) ⬇️
Flag Coverage Δ
unit 57.6391% <100.0000%> (-0.0260%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11253        +/-   ##
================================================
- Coverage   57.6650%   57.6391%   -0.0260%     
================================================
  Files           850        850                
  Lines        126059     126218       +159     
================================================
+ Hits          72692      72751        +59     
- Misses        47971      48065        +94     
- Partials       5396       5402         +6     

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2024
@hongyunyan hongyunyan changed the title ticdc: support user to specify the sync point start ts ticdc: change the calculation of first sync point ts Jun 11, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 11, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
cdc/owner/changefeed.go Outdated Show resolved Hide resolved
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 12, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-11 10:16:30.012940032 +0000 UTC m=+459744.066251955: ☑️ agreed by sdojjy.
  • 2024-06-12 09:41:03.385866647 +0000 UTC m=+544017.439178571: ☑️ agreed by lidezhu.

@hongyunyan
Copy link
Collaborator Author

/retest

1 similar comment
@hongyunyan
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit fa1a2b3 into pingcap:master Jun 13, 2024
28 checks passed
benmeadowcroft added a commit to qiancai/docs that referenced this pull request Jun 21, 2024
Docs: Added TiCDC sync-point-interval change to RN

Updated RN to include TiCDC change in pingcap/tiflow#11253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to specify the initial value of syncpointTs with parameter
3 participants