-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticdc: change the calculation of first sync point ts #11253
Conversation
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11253 +/- ##
================================================
- Coverage 57.6650% 57.6391% -0.0260%
================================================
Files 850 850
Lines 126059 126218 +159
================================================
+ Hits 72692 72751 +59
- Misses 47971 48065 +94
- Partials 5396 5402 +6 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lidezhu, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Docs: Added TiCDC sync-point-interval change to RN Updated RN to include TiCDC change in pingcap/tiflow#11253
What problem does this PR solve?
Issue Number: close #11212
What is changed and how it works?
In this PR, we change the calculation of the first sync point ts.
As before, we use startTs as the first sync point ts.
Afer the PR, the first-sync-point-ts = k * sync-point-ts-interval,
and we will choose the minimal k that satisfy the first-sync-point-ts >= startTs.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note