Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server(ticdc): remove unused cdc-v2 configuration #11355

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jun 27, 2024

What problem does this PR solve?

Issue Number: close #11354

What is changed and how it works?

The below cdc-v2 configuration is not used anymore, and ticdc will implement the new architecture in another way, so remove it to reduce the codebase.

furthermore, it's a debug configuration, so we can remove it without breaking the compatibility

[debug.cdc-v2]
enable=false

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Jun 27, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1564%. Comparing base (ea35677) to head (5d5efcb).

Additional details and impacted files
Components Coverage Δ
cdc 59.5884% <ø> (+0.0039%) ⬆️
dm 50.0481% <ø> (+0.0115%) ⬆️
engine 53.2167% <ø> (-0.0226%) ⬇️
Flag Coverage Δ
unit 55.1564% <ø> (+0.0009%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11355        +/-   ##
================================================
+ Coverage   55.1554%   55.1564%   +0.0009%     
================================================
  Files          1002       1001         -1     
  Lines        137399     137324        -75     
================================================
- Hits          75783      75743        -40     
+ Misses        56073      56042        -31     
+ Partials       5543       5539         -4     
---- 🚨 Try these New Features:

Copy link
Contributor

ti-chi-bot bot commented Jun 27, 2024

@kevin-xianliu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, kevin-xianliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-27 02:50:15.636285726 +0000 UTC m=+860742.121774558: ☑️ agreed by 3AceShowHand.
  • 2024-06-28 01:59:29.4900454 +0000 UTC m=+944095.975534238: ☑️ agreed by asddongmen.

@sdojjy
Copy link
Member Author

sdojjy commented Jun 28, 2024

/retest-required

3 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented Jul 1, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Jul 2, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Aug 19, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 7, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

@sdojjy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test 5d5efcb link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove unused cdc-v2 configuration
4 participants