-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server(ticdc): remove unused cdc-v2 configuration #11355
base: master
Are you sure you want to change the base?
Conversation
/retest-required |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11355 +/- ##
================================================
+ Coverage 55.1554% 55.1564% +0.0009%
================================================
Files 1002 1001 -1
Lines 137399 137324 -75
================================================
- Hits 75783 75743 -40
+ Misses 56073 56042 -31
+ Partials 5543 5539 -4
|
@kevin-xianliu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, asddongmen, kevin-xianliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest-required |
3 similar comments
/retest-required |
/retest-required |
/retest-required |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sdojjy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #11354
What is changed and how it works?
The below
cdc-v2
configuration is not used anymore, and ticdc will implement the new architecture in another way, so remove it to reduce the codebase.furthermore, it's a debug configuration, so we can remove it without breaking the compatibility
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note