Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): update defaultSupportVectorVersion #11634

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Sep 29, 2024

What problem does this PR solve?

Issue Number: ref #11530

What is changed and how it works?

As title.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2024
@wk989898
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.3779%. Comparing base (4e177d9) to head (e4bbf41).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.0227% <ø> (-0.0270%) ⬇️
dm 51.0221% <ø> (-0.0484%) ⬇️
engine 63.4020% <ø> (+0.0141%) ⬆️
Flag Coverage Δ
unit 57.3779% <ø> (-0.0308%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11634        +/-   ##
================================================
- Coverage   57.4086%   57.3779%   -0.0308%     
================================================
  Files           852        852                
  Lines        126845     126845                
================================================
- Hits          72820      72781        -39     
- Misses        48627      48660        +33     
- Partials       5398       5404         +6     

@wk989898 wk989898 changed the title sink(ticdc): fix typo sink(ticdc): update defaultSupportVectorVersion Sep 29, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 29, 2024
@wk989898
Copy link
Contributor Author

/retest

Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-29 07:14:17.206311084 +0000 UTC m=+166212.626524095: ☑️ agreed by hongyunyan.
  • 2024-09-29 07:25:12.335279459 +0000 UTC m=+166867.755492472: ☑️ agreed by lidezhu.

@wk989898
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit a834840 into pingcap:master Sep 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants