-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] dm: fix integration test in rocky8.9 #11751
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @River2000i. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11751 +/- ##
================================================
+ Coverage 55.1510% 55.1576% +0.0065%
================================================
Files 1002 1002
Lines 137399 137399
================================================
+ Hits 75777 75786 +9
+ Misses 56074 56068 -6
+ Partials 5548 5545 -3 |
/retest
|
/retest
|
@@ -34,14 +34,15 @@ EOF | |||
--data-dir "$WORK_DIR/pd" & | |||
# wait until PD is online... | |||
i=0 | |||
while ! curl "http://$PD_ADDR/pd/api/v1/version"; do | |||
while curl "http://$PD_ADDR/pd/api/v1/version"; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If curl return exit code is not 0, it will not retry such as:
Starting PD...
Release Version: v8.5.0-alpha-23-gc8c75510a
Edition: Community
Git Commit Hash: c8c75510a3583c669a962c41e6117157f3d19dca
Git Branch: master
UTC Build Time: 2024-11-14 10:14:13
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (7) Failed to connect to 127.0.0.1 port 2379: Connection refused
script returned exit code 2
Seems check curl return without error(exit code is 0) is enough🤔
ref tiup: https://github.com/pingcap/tiup/blob/master/pkg/cluster/api/pdapi.go#L188-L195
@@ -16,12 +16,12 @@ DNS.1 = localhost | |||
IP.1 = 127.0.0.1 | |||
EOF | |||
|
|||
openssl ecparam -out "ca.key" -name prime256v1 -genkey | |||
openssl genrsa -out "ca.key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,8 +1,17 @@ | |||
-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update by dm/tests/tls/conf/generate_tls.sh
@River2000i: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #11752
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note