Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): limit encoder-concurrency to avoid OOM #11775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Nov 19, 2024

What problem does this PR solve?

Issue Number: close #11773

What is changed and how it works?

As title. The maximum value is CPU count * 10

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wk989898, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.1680%. Comparing base (ea35677) to head (5961029).

Additional details and impacted files
Components Coverage Δ
cdc 59.6172% <0.0000%> (+0.0328%) ⬆️
dm 50.0384% <ø> (+0.0019%) ⬆️
engine 53.2054% <ø> (-0.0339%) ⬇️
Flag Coverage Δ
unit 55.1680% <0.0000%> (+0.0126%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11775        +/-   ##
================================================
+ Coverage   55.1554%   55.1680%   +0.0126%     
================================================
  Files          1002       1002                
  Lines        137399     137402         +3     
================================================
+ Hits          75783      75802        +19     
+ Misses        56073      56059        -14     
+ Partials       5543       5541         -2     
---- 🚨 Try these New Features:

Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

@wk989898: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test 5961029 link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDC OOM when encoder-concurrency is too large
1 participant