kv/client: fix gRPC connection pool, don't close conn when meeting error (#1196) #1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1196 to release-4.0
What problem does this PR solve?
In an internal test, TiCDC can't recover from a TiKV crash or recovery.
We meet endless following errors after killing a TiKV, where
store=172.16.4.197:21160
is the killed TiKV server.On the other side, recovers a TiKV server meets following error
What is changed and how it works?
We don't close gPRC conn here, let it goes into TransientFailure. If the store recovers, the gPRC conn can be reused.
TODO:
Check List
Tests
Release note