Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: fix max-batch-size (#1250) #1253

Merged
merged 1 commit into from
Dec 30, 2020
Merged

sink: fix max-batch-size (#1250) #1253

merged 1 commit into from
Dec 30, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1250 to release-4.0

What problem does this PR solve?

  • max-batch-size does not work.

What is changed and how it works?

  • fixed bug in passing max-batch-size to codec.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fixed bug in passing max-batch-size to codec.

@liuzix @ti-srebot
cherry pick pingcap#1250 to release-4.0
de91691 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 30, 2020
Merged
@ti-srebot ti-srebot added type/bugfix This PR fixes a bug. component/sink Sink component. status/ptal Could you please take a look? type/4.0-cherry-pick labels Dec 30, 2020
@ti-srebot ti-srebot added this to the v4.0.10 milestone Dec 30, 2020
@zier-one zier-one changed the base branch from release-4.0 to release-4.0-pending December 30, 2020 05:10
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2020
@codecov-io
Copy link

codecov-io commented Dec 30, 2020 •
edited
Loading

Codecov Report

Merging #1253 (de91691) into release-4.0 (6b7fb14) will decrease coverage by 0.0340%.
The diff coverage is 50.0000%.

@@                 Coverage Diff                 @@
##           release-4.0      #1253        +/-   ##
===================================================
- Coverage      45.9675%   45.9335%   -0.0340%     
===================================================
  Files              112        112                
  Lines            11767      11767                
===================================================
- Hits              5409       5405         -4     
- Misses            5747       5751         +4     
  Partials           611        611

@amyangfei amyangfei changed the base branch from release-4.0-pending to release-4.0 December 30, 2020 05:57
@zier-one
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei merged commit e65ce07 into pingcap:release-4.0 Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@liuzix liuzix

Labels
component/sink Sink component. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @codecov-io @zier-one @amyangfei @liuzix