Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: kv client should handle event with invalid request id #1325

Merged
merged 3 commits into from
Jan 26, 2021
Merged

tests: kv client should handle event with invalid request id #1325

merged 3 commits into from
Jan 26, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Improve unit test of kv client, part of #1292

What is changed and how it works?

  • Test kv client should drop an event if its request-id is outdated
  • Test kv client should return an error when receiving a new subscription but the corresponding region is not found in pending regions

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Jan 21, 2021
@amyangfei amyangfei added this to the v4.0.11 milestone Jan 21, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Jan 21, 2021
@amyangfei amyangfei mentioned this pull request Jan 21, 2021
Closed
23 tasks
@zier-one
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@liuzix
Copy link
Contributor

liuzix commented Jan 25, 2021

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 25, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 1335

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@amyangfei merge failed.

@amyangfei
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@amyangfei merge failed.

@amyangfei amyangfei merged commit f5d7cfa into pingcap:master Jan 26, 2021
@amyangfei amyangfei deleted the kv-client-ut-region-info-error branch January 26, 2021 02:05
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Jan 26, 2021
@amyangfei @ti-srebot
cherry pick pingcap#1325 to release-4.0
0a69f47 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1339

ti-srebot added a commit that referenced this pull request Jan 26, 2021
@ti-srebot
tests: kv client should handle event with invalid request id (#1325) (#…
7286568 
…1339)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @zier-one @liuzix @ti-srebot