-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: fix unstable unit test (#1609) #1655
pipeline: fix unstable unit test (#1609) #1655
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #1655 +/- ##
================================================
Coverage ? 52.6558%
================================================
Files ? 152
Lines ? 16059
Branches ? 0
================================================
Hits ? 8456
Misses ? 6705
Partials ? 898 |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: df72b47
|
cherry-pick #1609 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1655
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Fix unstable unit test found in https://github.com/pingcap/ticdc/issues/1501#issuecomment-812846556
What is changed and how it works?
Add one more check for the logic that send message to closed pipeline.
Check List
Tests
Release note