Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/client: fix unstable unit test, where request id is not accurate #1674

Merged
merged 4 commits into from
Apr 16, 2021
Merged

kv/client: fix unstable unit test, where request id is not accurate #1674

merged 4 commits into from
Apr 16, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Apr 15, 2021 •
edited
Loading

What problem does this PR solve?

Fix a test failure in https://github.com/pingcap/ticdc/issues/1501#issuecomment-820027078

Note release-5.0 should be cherry-picked manually.

What is changed and how it works?

The cause is that when the mock TiKV server starts up for the second time, it could cost some time before it is available and kv client will try to request for more than one time.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Apr 15, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2021
@amyangfei amyangfei removed the request for review from 3pointer April 15, 2021 08:46
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Apr 15, 2021
@amyangfei
Copy link
Contributor Author

/run-check-release-note

@liuzix
Copy link
Contributor

liuzix commented Apr 15, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@zier-one
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@zier-one
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 60d35b5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@amyangfei
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 7f5a772 into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 16, 2021
@amyangfei @ti-srebot
cherry pick pingcap#1674 to release-4.0
0880e11 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1679

amyangfei added a commit to ti-srebot/ticdc that referenced this pull request Apr 29, 2021
@amyangfei
kv/client: fix unstable unit test, where request id is not accurate (p…
f3db866 
…ingcap#1674)
@amyangfei amyangfei mentioned this pull request Apr 29, 2021
Merged
@amyangfei amyangfei deleted the fix-unstable-unit-test branch April 29, 2021 13:39
amyangfei pushed a commit that referenced this pull request Apr 29, 2021
@ti-srebot
kv/client: support reconnect regions when no event received too long (#…
8158b03 
…1591,#1674,#1686) (#1668)
amyangfei added a commit to amyangfei/tiflow that referenced this pull request Jun 3, 2021
@amyangfei
kv/client: fix unstable unit test, where request id is not accurate (p…
355d8f2 
…ingcap#1674)
@amyangfei amyangfei mentioned this pull request Jun 3, 2021
Merged
ti-chi-bot pushed a commit that referenced this pull request Jun 10, 2021
@amyangfei
kv/client: cherry pick #1591,#1674,#1682,#1481,#1847,#1903 to release…
fc4adf4 
…-5.0 (#1922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @liuzix @zier-one @ti-chi-bot @ti-srebot