-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix flow control deadlock (release-4.0) #1779
*: fix flow control deadlock (release-4.0) #1779
Conversation
/run-all-tests |
/run-all-tests |
/run-integration-tests |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d2709e7
|
@liuzix: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1779 +/- ##
===================================================
+ Coverage 52.4990% 52.5740% +0.0750%
===================================================
Files 153 153
Lines 15926 15928 +2
===================================================
+ Hits 8361 8374 +13
+ Misses 6654 6644 -10
+ Partials 911 910 -1 |
What problem does this PR solve?
blockCallback
function, which will send event toflowControlOutCh
, the channel is full at that time.flowControlOutCh
is blocked bysendResolvedTs2Sink
(because they are in the same select branch)sendResolvedTs2Sink
, which needs to require a lock, however that lock is held by goroutine 2776What is changed and how it works?
Check List
Tests
Release note