Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: reduce memory consumption by reducing channel sizes (#1999) #2012

Merged
merged 4 commits into from
Jun 22, 2021
Merged

*: reduce memory consumption by reducing channel sizes (#1999) #2012

merged 4 commits into from
Jun 22, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1999

What problem does this PR solve?

  • TiCDC can OOM frequently on machines with memory less than 16GB.

What is changed and how it works?

  • Decreased the channel sizes in two places.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Reduce unnecessary memory consumption

@liuzix @ti-chi-bot
This is an automated cherry-pick of pingcap#1999
bfe8d08 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved component/kv-client TiKV kv log client component. status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jun 10, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 10, 2021
Merged
@ti-chi-bot ti-chi-bot requested a review from lonng June 10, 2021 03:07
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2021
@amyangfei amyangfei removed the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 10, 2021
@lonng lonng added this to the v5.0.3 milestone Jun 10, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2021
overvenus
overvenus approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve in advance, please merge this PR once it's ready.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 22, 2021
@amyangfei amyangfei removed the require-LGT1 Indicates that the PR requires an LGTM. label Jun 22, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b2df1a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@zier-one
Copy link
Contributor

/merge

2 similar comments
@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@e7c3a0f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2012   +/-   ##
================================================
  Coverage               ?   53.9965%           
================================================
  Files                  ?        164           
  Lines                  ?      17540           
  Branches               ?          0           
================================================
  Hits                   ?       9471           
  Misses                 ?       7074           
  Partials               ?        995

@ti-chi-bot ti-chi-bot merged commit 9e0d54d into pingcap:release-5.0 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei amyangfei approved these changes

@lonng lonng Awaiting requested review from lonng

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@liuzix liuzix

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @amyangfei @zier-one @codecov-commenter @overvenus @lonng @liuzix