Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor: cancel all tables all at once #2089

Merged
merged 2 commits into from
Jun 18, 2021
Merged

processor: cancel all tables all at once #2089

merged 2 commits into from
Jun 18, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jun 18, 2021

What problem does this PR solve?

  • The processor cancels tables one by one, meaning that the next table is not cancelled until the first table has fully exited. This causes risks of deadlocking.

What is changed and how it works?

  • Cancel them all at once.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@liuzix
Copy link
Contributor Author

liuzix commented Jun 18, 2021

/run-integration-tests

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2089 (27ea4ec) into master (0138edc) will increase coverage by 16.2816%.
The diff coverage is 60.8783%.

@@                Coverage Diff                @@
##             master      #2089         +/-   ##
=================================================
+ Coverage   37.8006%   54.0822%   +16.2816%     
=================================================
  Files           110        164         +54     
  Lines         11394      17527       +6133     
=================================================
+ Hits           4307       9479       +5172     
- Misses         6662       7017        +355     
- Partials        425       1031        +606

@ti-chi-bot
Copy link
Member

@asddongmen: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei amyangfei added needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. release-blocker This issue blocks a release. Please solve it ASAP. labels Jun 18, 2021
@amyangfei amyangfei added this to the v5.1.0 milestone Jun 18, 2021
@amyangfei amyangfei added the needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. label Jun 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2021
@zier-one
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@amyangfei
Copy link
Contributor

/run-leak-tests

@zier-one
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor

/run-leak-tests

@zier-one
Copy link
Contributor

/cancel merge

@amyangfei
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
@zier-one zier-one removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. status/can-merge Indicates a PR has been approved by a committer. labels Jun 18, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@amyangfei
Copy link
Contributor

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@zier-one
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27ea4ec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@zier-one
Copy link
Contributor

/rebuild

@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei amyangfei removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
@ti-chi-bot ti-chi-bot merged commit 75fc785 into pingcap:master Jun 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2094.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2095.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 18, 2021
@liuzix @ti-chi-bot
This is an automated cherry-pick of pingcap#2089
23ced30 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2021
Merged
@amyangfei amyangfei added the needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. label Jun 18, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 18, 2021
@liuzix @ti-chi-bot
This is an automated cherry-pick of pingcap#2089
8db68c4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 18, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2096.

liuzix added a commit to liuzix/ticdc that referenced this pull request Jun 24, 2021
@liuzix
processor: cancel all tables all at once (pingcap#2089)
c1e312c
@liuzix liuzix mentioned this pull request Jun 24, 2021
Merged
@amyangfei amyangfei mentioned this pull request Jun 25, 2021
Closed
ti-chi-bot added a commit that referenced this pull request Jul 17, 2021
@ti-chi-bot
processor: cancel all tables all at once (#2089) (#2094)
d0c5faf
ti-chi-bot added a commit that referenced this pull request Jul 18, 2021
@ti-chi-bot
processor: cancel all tables all at once (#2089) (#2095)
2e118a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@asddongmen asddongmen asddongmen approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. release-blocker This issue blocks a release. Please solve it ASAP. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @codecov-commenter @ti-chi-bot @zier-one @amyangfei @asddongmen