Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: only diff the go.mod and go.sum #2163

Merged
merged 3 commits into from
Jun 28, 2021
Merged

tools: only diff the go.mod and go.sum #2163

merged 3 commits into from
Jun 28, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jun 25, 2021 •
edited
Loading

What problem does this PR solve?

None

What is changed and how it works?

Only diff go.sum, otherwise there will be a lot of diff information after modifying the other codes.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jun 25, 2021
@amyangfei amyangfei added this to the v5.1.1 milestone Jun 25, 2021
lonng
lonng approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@lonng: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2021
lichunzhu
lichunzhu approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2021
@Rustin170506 Rustin170506 changed the title tools: only diff the go.sum tools: only diff the go.mod and go.sum Jun 28, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 44c98a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2021
@ti-chi-bot ti-chi-bot merged commit 24ce557 into pingcap:master Jun 28, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2174.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2175.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2176.

ti-chi-bot added a commit that referenced this pull request Jul 7, 2021
@ti-chi-bot
tools: only diff the go.mod and go.sum (#2163) (#2174)
4bd16ab
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Jul 9, 2021
@Rustin170506 @3AceShowHand
tools: only diff the go.mod and go.sum (pingcap#2163)
84b426a
ti-chi-bot added a commit that referenced this pull request Jul 9, 2021
@ti-chi-bot
tools: only diff the go.mod and go.sum (#2163) (#2176)
6103295
ti-chi-bot added a commit that referenced this pull request Jul 12, 2021
@ti-chi-bot
tools: only diff the go.mod and go.sum (#2163) (#2175)
bf0a29e
@Rustin170506 Rustin170506 deleted the rustin-patch-tools branch August 15, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@lonng lonng lonng approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @ti-chi-bot @CLAassistant @lichunzhu @lonng @amyangfei