Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client,server: better err msg when PD endpoint missing certificate (#2138) #2186

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2138

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/1973

What is changed and how it works?

Add better err msg.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Better err msg when PD endpoint missing certificate

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jun 29, 2021
@ti-chi-bot ti-chi-bot requested a review from zier-one June 29, 2021 05:23
@amyangfei amyangfei added this to the v5.1.1 milestone Jun 30, 2021
@ben1009
Copy link
Contributor

ben1009 commented Jul 5, 2021

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@bf28daa). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #2186   +/-   ##
================================================
  Coverage               ?   53.9499%           
================================================
  Files                  ?        164           
  Lines                  ?      17570           
  Branches               ?          0           
================================================
  Hits                   ?       9479           
  Misses                 ?       7081           
  Partials               ?       1010           

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 9, 2021
@lonng
Copy link
Contributor

lonng commented Jul 9, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 53c0ce5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 9, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit bb4e768 into pingcap:release-5.1 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants