-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add log configuration items to the config file (#2182) #2196
config: Add log configuration items to the config file (#2182) #2196
Conversation
@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4810410
|
Codecov Report
@@ Coverage Diff @@
## release-5.1 #2196 +/- ##
================================================
Coverage ? 53.9135%
================================================
Files ? 164
Lines ? 17567
Branches ? 0
================================================
Hits ? 9471
Misses ? 7088
Partials ? 1008 |
This is an automated cherry-pick of #2182
What problem does this PR solve?
Add log configuration items to the config file. #1384
What is changed and how it works?
Add logFileMaxSize, logFileMaxDays and logFileMaxBackups items when load config file.
Check List
Tests
Code changes
Related changes
Release note