changefeed: Fix changefeed fails immediately after being created successfully. (#2115)

[ti-chi-bot]

This is an automated cherry-pick of #2115

What problem does this PR solve?

Fix changefeed fails immediately after being created successfully.

Close #2113

What is changed and how it works?

Check List

Tests

• Manual test (add detailed scripts or steps below)

1. create three changefeeds(test1,test2,test3) and stop test3 until it blocks the gcSafepoint advance.

$ curl http://127.0.0.1:8300/api/v1/changefeeds?state=stopped
[
 {
  "id": "test3",
  "state": "stopped",
  "checkpoint-tso": 425790752871415809,
  "checkpoint-time": "2021-06-21 16:07:00.707",
  "error": null
 }

mysql> select * from mysql.tidb where VARIABLE_NAME="tikv_gc_safe_point";
+--------------------+-------------------------+--------------------------------------------------------------+
| VARIABLE_NAME      | VARIABLE_VALUE          | COMMENT                                                      |
+--------------------+-------------------------+--------------------------------------------------------------+
| tikv_gc_safe_point | 20210621-16:07:00 +0800 | All versions after safe point can be accessed. (DO NOT EDIT) |
+--------------------+-------------------------+--------------------------------------------------------------+
1 row in set (0.01 sec)

2. create changefeed test13 and let: --start-ts = ${test3's checkpointTs}.

$ ./bin/cdc cli changefeed create --sink-uri="blackhole://" --start-ts 425790752871415809 --changefeed-id="test13"
Create changefeed successfully!
ID: test13

3. test13 works well.

 $ curl http://127.0.0.1:8300/api/v1/changefeeds?state=normal
[
 {
  "id": "test13",
  "state": "normal",
  "checkpoint-tso": 425791107210674177,
  "checkpoint-time": "2021-06-21 16:29:32.404",
  "error": null
 },

Code changes

• None

Side effects

• None

Related changes

• Need to cherry-pick to the release branch

Release note

• No release note

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

@asddongmen: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[overvenus]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 723051d

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[codecov-commenter]

Codecov Report

Merging #2236 (b49f0de) into release-4.0 (753073a) will increase coverage by 0.5651%.
The diff coverage is 59.6037%.

@@                 Coverage Diff                 @@
##           release-4.0      #2236        +/-   ##
===================================================
+ Coverage      53.7661%   54.3313%   +0.5651%     
===================================================
  Files              153        166        +13     
  Lines            15958      19867      +3909     
===================================================
+ Hits              8580      10794      +2214     
- Misses            6475       8038      +1563     
- Partials           903       1035       +132