Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: fix concurrent map access in sink manager (#2249) #2300

Merged
merged 3 commits into from
Jul 19, 2021
Merged

sink: fix concurrent map access in sink manager (#2249) #2300

merged 3 commits into from
Jul 19, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2249

What problem does this PR solve?

  • There is an unsynchronized access to a shared map, which can cause runtime panic.

What is changed and how it works?

  • Lock it.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix minor runtime panic risk

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jul 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
@amyangfei amyangfei added this to the v5.1.1 milestone Jul 16, 2021
@amyangfei
Copy link
Contributor

/merge

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 19, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f856aa9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@amyangfei
Copy link
Contributor

/run-unit-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit a9d7bfb into pingcap:release-5.1 Jul 19, 2021
This was referenced Jul 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one Awaiting requested review from zier-one

@lonng lonng Awaiting requested review from lonng

Assignees

@liuzix liuzix

Labels
cherry-pick-approved Cherry pick PR approved by release team. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @amyangfei @lonng @liuzix