Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller,mounter,processor: always pull the old value internally (#2271) #2306

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2271

What problem does this PR solve?

ref: https://github.com/pingcap/ticdc/issues/2301

What is changed and how it works?

ticdc always pull the old value internally.

Because our new collation feature needs the old value to work properly. However, some users will not use old value, but may use new collation, so it needs to be configured by the user. (Users don't even know if they have new collation on)

To simplify this configuration and to make it easier for the user, we decided to:

  1. always use old value internally.
  2. the data output to the user needs to be in the correct format (without the old value configuration on, the old value cannot be output)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

None

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

  • puller,mounter,processor: always pull the old value internally

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? subject/usability Denotes an issue or pull request is related to usability. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jul 16, 2021
@amyangfei
Copy link
Contributor

Please fix CI, github.com/tikv/client-go/v2 is not available in all release branches, because https://github.com/pingcap/ticdc/pull/2109 is not cherry-picked. @hi-rustin

@Rustin170506
Copy link
Member

I will fix it.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 19, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0953c64

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@amyangfei
Copy link
Contributor

/run-leak-tests
/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@a9d7bfb). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #2306   +/-   ##
================================================
  Coverage               ?   56.0119%           
================================================
  Files                  ?        166           
  Lines                  ?      19769           
  Branches               ?          0           
================================================
  Hits                   ?      11073           
  Misses                 ?       7639           
  Partials               ?       1057           

@amyangfei
Copy link
Contributor

/run-integration-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? subject/usability Denotes an issue or pull request is related to usability. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants