-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puller,mounter,processor: always pull the old value internally (#2271) #2306
puller,mounter,processor: always pull the old value internally (#2271) #2306
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please fix CI, |
I will fix it. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0953c64
|
/run-leak-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.1 #2306 +/- ##
================================================
Coverage ? 56.0119%
================================================
Files ? 166
Lines ? 19769
Branches ? 0
================================================
Hits ? 11073
Misses ? 7639
Partials ? 1057 |
/run-integration-tests |
This is an automated cherry-pick of #2271
What problem does this PR solve?
ref: https://github.com/pingcap/ticdc/issues/2301
What is changed and how it works?
ticdc always pull the old value internally.
Because our
new collation
feature needs theold value
to work properly. However, some users will not use old value, but may use new collation, so it needs to be configured by the user. (Users don't even know if they have new collation on)To simplify this configuration and to make it easier for the user, we decided to:
Check List
Tests
Code changes
None
Side effects
Related changes
Release note