Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(refactor): Refine functions and improve event splitting code #2367

Merged
merged 10 commits into from
Jul 28, 2021
Merged

sink(refactor): Refine functions and improve event splitting code #2367

merged 10 commits into from
Jul 28, 2021

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

ref: #2301

What is changed and how it works?

Refine functions and improve event splitting code.

Check List

Tests

  • Unit test
  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2021
@Rustin170506 Rustin170506 added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. require-LGT1 Indicates that the PR requires an LGTM. labels Jul 25, 2021
@Rustin170506
Copy link
Member Author

Marking the change requires only one 👍 because it is simple and does not modify any logic.

overvenus
overvenus reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/processor/pipeline/sink.go Outdated Show resolved Hide resolved
@Rustin170506
Copy link
Member Author

/run-all-tests

@overvenus overvenus mentioned this pull request Jul 28, 2021
Merged
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b13eab7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/run-unit-tests

/run-leak-tests

@Rustin170506
Copy link
Member Author

/run-leak-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2367 (a5a3008) into master (e812b60) will increase coverage by 0.2243%.
The diff coverage is 66.6277%.

@@               Coverage Diff                @@
##             master      #2367        +/-   ##
================================================
+ Coverage   55.4466%   55.6709%   +0.2242%     
================================================
  Files           165        170         +5     
  Lines         19581      20420       +839     
================================================
+ Hits          10857      11368       +511     
- Misses         7685       7953       +268     
- Partials       1039       1099        +60

@ti-chi-bot ti-chi-bot merged commit f2526c1 into pingcap:master Jul 28, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 28, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#2367
35f804f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2397.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 28, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#2367
e21f1dc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2398.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2399.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2021
Merged
Rustin170506 added a commit to Rustin170506/tiflow that referenced this pull request Jul 30, 2021
@Rustin170506
sink(refactor): Refine functions and improve event splitting code (pi…
2533805 
…ngcap#2367)
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
sink(refactor): Refine functions and improve event splitting code (#2367
6f9c407 
) (#2399)
Rustin170506 added a commit to ti-chi-bot/tiflow that referenced this pull request Aug 1, 2021
@Rustin170506
This is an automated cherry-pick of pingcap#2367
95880c7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Rustin170506 added a commit to ti-chi-bot/tiflow that referenced this pull request Aug 1, 2021
@Rustin170506
This is an automated cherry-pick of pingcap#2367
8f459a9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Aug 2, 2021
@ti-chi-bot
sink(refactor): Refine functions and improve event splitting code (#2367
c426e49 
) (#2397)
ti-chi-bot added a commit that referenced this pull request Aug 2, 2021
@ti-chi-bot
sink(refactor): Refine functions and improve event splitting code (#2367
75b4d65 
) (#2398)
@amyangfei amyangfei mentioned this pull request Aug 24, 2021
Closed
@Rustin170506 Rustin170506 deleted the rustin-refactor-sink branch August 15, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben1009 ben1009 ben1009 left review comments

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @ti-chi-bot @overvenus @codecov-commenter @amyangfei @ben1009