Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_*: add create and update changefeed API #2472

Merged
merged 20 commits into from
Aug 16, 2021
Merged

http_*: add create and update changefeed API #2472

merged 20 commits into from
Aug 16, 2021

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

#2411

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

More tests will add ASAP.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note 

This PR add apis that list below to cdc server:
1. create changefeed
2. update changefeed

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 5, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 5, 2021
@asddongmen asddongmen self-assigned this Aug 5, 2021
@asddongmen asddongmen added status/ptal Could you please take a look? component/status-server Status server component. labels Aug 5, 2021
@asddongmen asddongmen added this to the v5.2.0 milestone Aug 5, 2021
@asddongmen asddongmen added the subject/new-feature Denotes an issue or pull request adding a new feature. label Aug 5, 2021
Rustin170506
Rustin170506 reviewed Aug 6, 2021
View reviewed changes
cdc/capture/http_handler.go Show resolved Hide resolved
cdc/capture/http_util.go Outdated Show resolved Hide resolved
ben1009
ben1009 reviewed Aug 9, 2021
View reviewed changes
cdc/capture/http_handler.go Outdated Show resolved Hide resolved
cdc/capture/http_handler.go Outdated Show resolved Hide resolved
cdc/capture/http_handler.go Show resolved Hide resolved
cdc/capture/http_handler.go Show resolved Hide resolved
cdc/capture/http_util.go Outdated Show resolved Hide resolved
cdc/capture/http_util.go Outdated Show resolved Hide resolved
cdc/capture/http_util.go Outdated Show resolved Hide resolved
@amyangfei amyangfei added release-blocker This issue blocks a release. Please solve it ASAP. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Aug 9, 2021
@asddongmen asddongmen mentioned this pull request Aug 10, 2021
Closed
11 tasks
@asddongmen asddongmen mentioned this pull request Aug 12, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #2472 (dd0c7f0) into master (21c466c) will decrease coverage by 0.4389%.
The diff coverage is 65.4450%.

@@               Coverage Diff                @@
##             master      #2472        +/-   ##
================================================
- Coverage   56.1544%   55.7154%   -0.4390%     
================================================
  Files           169        169                
  Lines         20465      20567       +102     
================================================
- Hits          11492      11459        -33     
- Misses         7848       8002       +154     
+ Partials       1125       1106        -19

@amyangfei
Copy link
Contributor

Please fix make check

@asddongmen
Copy link
Contributor Author

/run-unit-tests

@asddongmen
Copy link
Contributor Author

/run-kafka-tests

amyangfei
amyangfei reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/errors/errors.go Outdated Show resolved Hide resolved
asddongmen and others added 2 commits August 16, 2021 15:22
@asddongmen @amyangfei
Update pkg/errors/errors.go
cd466d2 
Co-authored-by: amyangfei <amyangfei@gmail.com>
@asddongmen
errors: fix make check error
61e912b
@asddongmen
Copy link
Contributor Author

/run-unit-tests

@ti-chi-bot
Copy link
Member

@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@zier-one zier-one added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 16, 2021
@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@asddongmen: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dbbd722

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@asddongmen
Copy link
Contributor Author

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit 43a2f19 into pingcap:master Aug 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 16, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2542.

ti-chi-bot added a commit that referenced this pull request Aug 17, 2021
@ti-chi-bot
http_*: add create and update changefeed API (#2472) (#2542)
86276ab
@asddongmen asddongmen deleted the open_api_2 branch August 20, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 left review comments

@amyangfei amyangfei amyangfei approved these changes

@ben1009 ben1009 ben1009 approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@asddongmen asddongmen

Labels
component/status-server Status server component. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
9 participants
@asddongmen @ti-chi-bot @purelind @codecov-commenter @amyangfei @ben1009 @Rustin170506 @zier-one @lonng