Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/client: add global grpc connection pool (#2511) #2531

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2511

What problem does this PR solve?

Add global gRPC connection pool in cdc server.

What is changed and how it works?

  • The gRPC pool is shared by all kv clients in a capture, the pool is created before a capture starts running and destroyed after a capture suicides or exits.
  • The gPRC pool maintains a bucket of gPRC connections for each TiKV store, the bucket is increased in a lazy way.
  • The gPRC pool provides a builtin recycle method, which is used to collect idle connections periodically.

Check List

Tests

  • Unit test
  • Integration test

Release note

Add a global gRPC connection pool and share gRPC connections among kv clients.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/kv-client TiKV kv log client component. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 15, 2021
@amyangfei amyangfei added this to the v4.0.15 milestone Aug 15, 2021
@amyangfei amyangfei force-pushed the cherry-pick-2511-to-release-4.0 branch from c3fb301 to 5c634df Compare August 15, 2021 13:27
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2531 (5c634df) into release-4.0 (753073a) will increase coverage by 1.3210%.
The diff coverage is 58.3305%.

@@                 Coverage Diff                 @@
##           release-4.0      #2531        +/-   ##
===================================================
+ Coverage      53.7661%   55.0872%   +1.3210%     
===================================================
  Files              153        164        +11     
  Lines            15958      19667      +3709     
===================================================
+ Hits              8580      10834      +2254     
- Misses            6475       7804      +1329     
- Partials           903       1029       +126     

@3AceShowHand
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 16, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5c634df

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit a70d779 into pingcap:release-4.0 Aug 16, 2021
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants