Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puller/sorter: remove manual GC settings (#2214) #2720

Merged
merged 5 commits into from
Sep 3, 2021
Merged

puller/sorter: remove manual GC settings (#2214) #2720

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba2860b
puller/sorter: remove manual GC setttings
overvenus Jul 4, 2021
2ad7bb3
Merge branch 'release-5.1' into cherry-pick-2214-to-release-5.1
ti-chi-bot Sep 2, 2021
24aba3e
Merge branch 'release-5.1' into cherry-pick-2214-to-release-5.1
ti-chi-bot Sep 2, 2021
e161064
Merge branch 'release-5.1' into cherry-pick-2214-to-release-5.1
ti-chi-bot Sep 3, 2021
ef9de95
Merge branch 'release-5.1' into cherry-pick-2214-to-release-5.1
ti-chi-bot Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions cdc/puller/sorter/backend_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import (
"os"
"path/filepath"
"reflect"
"runtime"
"runtime/debug"
"sync"
"sync/atomic"
"time"
Expand Down Expand Up @@ -133,18 +131,6 @@ func newBackEndPool(dir string, captureAddr string) (*backEndPool, error) {
atomic.StoreInt32(&ret.memPressure, int32(memPressure))
}

if memPressure := ret.memoryPressure(); memPressure > 50 {
log.Debug("unified sorter: high memory pressure", zap.Int32("memPressure", memPressure),
zap.Int64("usedBySorter", ret.sorterMemoryUsage()))
// Increase GC frequency to avoid unnecessary OOMs
debug.SetGCPercent(10)
if memPressure > 80 {
runtime.GC()
}
} else {
debug.SetGCPercent(50)
}

// garbage collect temporary files in batches
freedCount := 0
for i := range ret.cache {
Expand Down