Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puller/sorter: remove manual GC settings (#2214) #2721

Merged
merged 6 commits into from
Sep 5, 2021
Merged

puller/sorter: remove manual GC settings (#2214) #2721

merged 6 commits into from
Sep 5, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2214

What problem does this PR solve?

Do not change default GC settings, it could reduce the minimum mutator utilization and lead to #2202.

Close #2202

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Capturing 6k tables.

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix gRPC keepalive error when memory pressure is high.

@overvenus @ti-chi-bot
puller/sorter: remove manual GC setttings
ad1f521 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/sorter Sorter component. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 2, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 2, 2021
@amyangfei amyangfei added this to the v5.2.1 milestone Sep 2, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ad1f521

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2021
@overvenus
Copy link
Member

/run-unit-tests
/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2 /tiflash=release-5.2

@amyangfei
Copy link
Contributor

/run-kafka-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2 /tiflash=release-5.2

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@overvenus
Copy link
Member

/run-kafka-tests
/run-integration-tests

@overvenus
Copy link
Member

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit e42cf4c into pingcap:release-5.2 Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix liuzix approved these changes

@lonng lonng Awaiting requested review from lonng

Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/sorter Sorter component. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @amyangfei @overvenus @liuzix @nongfushanquan