-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink: fix codec json encoding with non binary string (#2764) #2782
sink: fix codec json encoding with non binary string (#2764) #2782
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b6d108a
|
/run-integration-tests |
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #2782 +/- ##
===================================================
- Coverage 55.4760% 55.4564% -0.0196%
===================================================
Files 165 165
Lines 19841 19848 +7
===================================================
Hits 11007 11007
- Misses 7786 7793 +7
Partials 1048 1048 |
This is an automated cherry-pick of #2764
What problem does this PR solve?
Close #2758
Note we still don't known in which scenario the column value is
string
instead of[]byte
, need more investigation.What is changed and how it works?
The column value type of
mysql.TypeString
,mysql.TypeVarString
,mysql.TypeVarchar
could be eitherstring
or[]byte
, we should consider both of these two types when converting a row column value to json encoding.Check List
Tests
Release note