Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pkg/context): migrate test-infra to testify for pkg/context pkg #2862

Merged
merged 4 commits into from
Sep 23, 2021
Merged

test(pkg/context): migrate test-infra to testify for pkg/context pkg #2862

merged 4 commits into from
Sep 23, 2021

Conversation

maxshuang
Copy link
Contributor

@maxshuang maxshuang commented Sep 22, 2021 •
edited
Loading

What problem does this PR solve?

migrate test-infra to testify for pkg/context pkg，close issue #2859, close issue #2874

What is changed and how it works?

  1. migrate test-infra from gocheck to testify
  2. migrate leak-test from testleak to goleak

Check List

Tests

  • Unit test

Code changes

Release note 

migrate test-infra to testify for pkg/context pkg

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 22, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 22, 2021
@maxshuang
Copy link
Contributor Author

/run-all-tests

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-all-tests

@maxshuang
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added this to the v5.3.0 milestone Sep 22, 2021
@amyangfei amyangfei added the component/test Unit tests and integration tests component. label Sep 22, 2021
amyangfei
amyangfei reviewed Sep 22, 2021
View reviewed changes
pkg/util/leak_helper.go Outdated
"go.uber.org/goleak"
)

func IgnoreEtcdAndOpencensusLeak(m *testing.M) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a parameters ...goleak.Option to allow more customized ignore function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i will change the function name also.

@ben1009
Copy link
Contributor

ben1009 commented Sep 22, 2021

The pr description may need modify a bit. Rest lgtm

overvenus
overvenus approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2021
@maxshuang
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #2862 (b3d998d) into master (11e574c) will increase coverage by 3.9014%.
The diff coverage is 54.2402%.

@@               Coverage Diff                @@
##             master      #2862        +/-   ##
================================================
+ Coverage   55.3406%   59.2420%   +3.9013%     
================================================
  Files           164        181        +17     
  Lines         19754      18340      -1414     
================================================
- Hits          10932      10865        -67     
+ Misses         7790       6525      -1265     
+ Partials       1032        950        -82

@maxshuang
Copy link
Contributor Author

@ben1009 @3AceShowHand PTLA , thanks.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2021
@maxshuang
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-integration-tests

@ben1009
Copy link
Contributor

ben1009 commented Sep 23, 2021

/run-kafka-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b3d998d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2021
@ti-chi-bot ti-chi-bot merged commit a01719a into pingcap:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@ben1009 ben1009 ben1009 approved these changes

@amyangfei amyangfei amyangfei approved these changes

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@maxshuang @ti-chi-bot @ben1009 @codecov-commenter @amyangfei @overvenus