Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pkg/filter): migrate test-infra to testify for pkg/filter pkg #2937

Merged
merged 10 commits into from
Sep 30, 2021
Merged

test(pkg/filter): migrate test-infra to testify for pkg/filter pkg #2937

merged 10 commits into from
Sep 30, 2021

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

migrate test-infra to testify for pkg/filter pkg, close #2936

What is changed and how it works?

  1. migrate test-infra from gocheck to testify
  2. migrate leak test from leaktest to goleak

Check List

Tests

  • Unit test
  • Integration test

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • ben1009

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 26, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2021
@maxshuang
Copy link
Contributor Author

/run-kafka-tests
/run-integration-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cbb93b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@maxshuang
Copy link
Contributor Author

/run-kafka-tests
/run-integration-tests

@maxshuang
Copy link
Contributor Author

/run-kafka-tests
/run-integration-tests

@maxshuang
Copy link
Contributor Author

/run-kafka-tests

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-kafka-tests

@maxshuang
Copy link
Contributor Author

/run-kafka-tests

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-kafka-tests

@ti-chi-bot
Copy link
Member

@maxshuang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

Merging #2937 (722335a) into master (11e574c) will increase coverage by 3.8680%.
The diff coverage is 53.6585%.

@@               Coverage Diff                @@
##             master      #2937        +/-   ##
================================================
+ Coverage   55.3406%   59.2087%   +3.8680%     
================================================
  Files           164        181        +17     
  Lines         19754      18325      -1429     
================================================
- Hits          10932      10850        -82     
+ Misses         7790       6525      -1265     
+ Partials       1032        950        -82     

@ti-chi-bot ti-chi-bot merged commit 6ebd167 into pingcap:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for pkg/filter pkg
6 participants