Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pkg/pipeline): migrate test-infra to testify for pkg/pipeline pkg #2984

Merged
merged 1 commit into from
Oct 9, 2021
Merged

test(pkg/pipeline): migrate test-infra to testify for pkg/pipeline pkg #2984

merged 1 commit into from
Oct 9, 2021

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Oct 8, 2021 •
edited
Loading

What problem does this PR solve?

close #2954

What is changed and how it works?

  1. migrate test-infra from gocheck to testify
  2. migrate leak-test from testleak to goleak

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Release note 

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2021
@pingcap pingcap deleted a comment from CLAassistant Oct 8, 2021
@amyangfei amyangfei added the component/test Unit tests and integration tests component. label Oct 9, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Oct 9, 2021
@CharlesCheung96
Copy link
Contributor Author

/run-kafka-tests
/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2984 (8b30c7b) into master (3c3b915) will decrease coverage by 0.7237%.
The diff coverage is 50.7936%.

@@               Coverage Diff                @@
##             master      #2984        +/-   ##
================================================
- Coverage   57.2251%   56.5013%   -0.7238%     
================================================
  Files           163        185        +22     
  Lines         19453      20442       +989     
================================================
+ Hits          11132      11550       +418     
- Misses         7261       7729       +468     
- Partials       1060       1163       +103

CharlesCheung96
CharlesCheung96 commented Oct 9, 2021
View reviewed changes
pkg/pipeline/pipeline_test.go
@@ -290,12 +281,11 @@ func (n *throwNode) Receive(ctx NodeContext) error {
}

func (n *throwNode) Destroy(ctx NodeContext) error {
n.c.Assert(map[int]bool{4: true, 6: true}, check.HasKey, n.index)
require.Contains(n.t, map[int]bool{4: true, 6: true}, n.index)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this rule to the testify.pattern script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW，please remove the release note in the pr body. We need no release note for each pr but a total release note for the whole testify change. @CharlesCheung96

maxshuang
maxshuang approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@maxshuang maxshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@maxshuang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2021
@amyangfei amyangfei added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 9, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b30c7b

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 9, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 380afb3 into pingcap:master Oct 9, 2021
@CharlesCheung96 CharlesCheung96 deleted the fix_2954_pkg_pipeline_testify branch October 9, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang approved these changes

@amyangfei amyangfei amyangfei approved these changes

@ben1009 ben1009 Awaiting requested review from ben1009

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for pkg/pipeline pkg
5 participants
@CharlesCheung96 @ti-chi-bot @codecov-commenter @amyangfei @maxshuang