Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: ignore the empty row event #3144

Merged
merged 6 commits into from
Oct 27, 2021
Merged

sink: ignore the empty row event #3144

merged 6 commits into from
Oct 27, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Oct 27, 2021 •
edited
Loading

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/2612.

What is changed and how it works?

ignore the empty row event.

Check List

Tests

  • Unit test (TBD)

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@Rustin170506
Copy link
Member Author

Rustin170506 commented Oct 27, 2021 •
edited
Loading

/hold

  • test

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

Several protocols tested locally do not send empty messages or changefeed failures anymore.

/cc @amyangfei @liuzix

Could you please take a look? Thanks!

@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Oct 27, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Oct 27, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4feb2c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2021
@ti-chi-bot ti-chi-bot merged commit 7b49a53 into pingcap:master Oct 27, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 27, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3147.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 27, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3148.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 27, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3149.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 27, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3150.

ti-chi-bot added a commit that referenced this pull request Nov 1, 2021
@ti-chi-bot
sink: ignore the empty row event (#3144) (#3150)
14b4aaf
ti-chi-bot added a commit that referenced this pull request Nov 1, 2021
@ti-chi-bot
sink: ignore the empty row event (#3144) (#3147)
8a9224a
ti-chi-bot added a commit that referenced this pull request Nov 2, 2021
@ti-chi-bot
sink: ignore the empty row event (#3144) (#3149)
7a81d7c
ti-chi-bot added a commit that referenced this pull request Nov 13, 2021
@ti-chi-bot
sink: ignore the empty row event (#3144) (#3148)
eb4dc1c
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-row branch August 15, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.

Some transaction(s) could generate empty values in open protocol
4 participants
@Rustin170506 @ti-chi-bot @amyangfei @3AceShowHand