Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add changefeed checkepoint catch-up ETA (#3300) #3312

Merged
merged 3 commits into from
Nov 10, 2021
Merged

metrics: add changefeed checkepoint catch-up ETA (#3300) #3312

merged 3 commits into from
Nov 10, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3300

What problem does this PR solve?

Add changefeed checkepoint catch-up ETA

Check List

Tests

  • Manual test (add detailed scripts or steps below)

image

Release note 

Show changefeed checkepoint catch-up ETA in metrics.

@overvenus @ti-chi-bot
metrics: add changefeed checkepoint catch-up ETA
19661aa 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/metrics-logging Metrics and logging component. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 6, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2021
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. label Nov 6, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 9, 2021
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member Author

@VelocityLight: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2021

/run-all-tests

@amyangfei amyangfei added this to the v5.3.0 milestone Nov 10, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4c65d14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2021
@ti-chi-bot ti-chi-bot merged commit 8c76bc8 into pingcap:release-5.3 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @VelocityLight @zhouqiang-cl @Leavrth @amyangfei @overvenus