Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd_worker: batch etcd patch (#3277) #3390

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 11, 2021

This is an automated cherry-pick of #3277
This PR also include: https://github.com/pingcap/ticdc/pull/3681

What problem does this PR solve?

This PR is an improvement to the issue's(#3112 ) fix.

What is changed and how it works?

  1. Batch as many changefeed patches as possible into a batch and submit them as an etcd transaction, which can reduce the etcd qps.
    2. Get the response from etcd watchCh as much as possible to reduce the number of etcd worker tick reactor.
  2. Add metrics for some key points in EtcdWorker.

Check List

Tests

  • Unit test

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

1. Fix the issue that TiCDC commits a txn contained too many operations to etcd which will caused txn commit fails.
2. Reduce the number of txn commit requests initiated by cdc to etcd which reducing the pressure of etcd server and network communication overhead.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ticdc Issues or PRs related to TiCDC. component/replica-model Replication model component. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. subject/performance Denotes an issue or pull request is related to replication performance. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Nov 11, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2021
@asddongmen
Copy link
Contributor

/run-unit-tests

@asddongmen
Copy link
Contributor

/run-integration-tests

@asddongmen
Copy link
Contributor

/run-integration-tests

@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3390 (8588ac6) into release-4.0 (753073a) will increase coverage by 3.2791%.
The diff coverage is 67.5675%.

@@                 Coverage Diff                 @@
##           release-4.0      #3390        +/-   ##
===================================================
+ Coverage      53.7661%   57.0452%   +3.2791%     
===================================================
  Files              153        170        +17     
  Lines            15958      19758      +3800     
===================================================
+ Hits              8580      11271      +2691     
- Misses            6475       7427       +952     
- Partials           903       1060       +157     

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8588ac6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 10, 2021
@ti-chi-bot ti-chi-bot merged commit f37133e into pingcap:release-4.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. subject/performance Denotes an issue or pull request is related to replication performance. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants