Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd_worker: add timeout for etcd txn and watchCh (#3667) #3757

Closed
wants to merge 2 commits into from
Closed

etcd_worker: add timeout for etcd txn and watchCh (#3667) #3757

wants to merge 2 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3667

What problem does this PR solve?

#3615

What is changed and how it works?

Check List

Tests

  • Unit test.

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

Try to fix owner stuck caused by etcd txn timeout or etcd watch channel blocked in EtcdWorker.

@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#3667
d2465bb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 7, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 7, 2021
Merged
@ti-chi-bot ti-chi-bot added component/replica-model Replication model component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Dec 7, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2021
@asddongmen asddongmen mentioned this pull request Dec 20, 2021
Merged
@asddongmen
Copy link
Contributor

This CP is included in #3393

@asddongmen asddongmen closed this Dec 20, 2021
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asddongmen asddongmen

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @asddongmen @VelocityLight