dep(dm): update go-mysql #3914

lance6716 · 2021-12-16T06:38:06Z

What problem does this PR solve?

close #3847
close https://github.com/pingcap/ticdc/issues/3419

What is changed and how it works?

update dependency to include the fix

Check List

Tests

No code

Code changes

Side effects

Related changes

Need to cherry-pick to the release branch

Release note

fix a bug that DM may report "invalid sequence" when upstream is MySQL 8.0
fix a bug that upstream will die on SHOW SLAVE HOSTS

ti-chi-bot · 2021-12-16T06:38:07Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Ehco1996
lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov-commenter · 2021-12-16T06:57:10Z

Codecov Report

Merging #3914 (7727afd) into master (3873d39) will decrease coverage by 1.9630%.
The diff coverage is 44.2583%.

Flag	Coverage Δ
cdc	`57.9526% <26.0000%> (-0.2839%)`	⬇️
dm	`52.7277% <46.7391%> (-3.3068%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3914        +/-   ##
================================================
- Coverage   57.0741%   55.1110%   -1.9631%     
================================================
  Files           478        481         +3     
  Lines         56551      58745      +2194     
================================================
+ Hits          32276      32375        +99     
- Misses        20978      23097      +2119     
+ Partials       3297       3273        -24

lance6716 · 2021-12-16T09:27:03Z

/cc @Ehco1996 @lichunzhu

lichunzhu · 2021-12-16T09:43:41Z

/merge

ti-chi-bot · 2021-12-16T09:43:43Z

This pull request has been accepted and is ready to merge.

Commit hash: 7727afd

lance6716 · 2021-12-16T11:15:36Z

/merge

purelind · 2021-12-16T13:25:59Z

/run-kafka-integration-test
/run-integration-tests

lance6716 · 2021-12-16T14:29:01Z

/hold

I'll update go-mysql again to include go-mysql-org/go-mysql#655 tomorrow, and an integration test is needed for SHOW SLAVE HOSTS

…ate-go-mysql

lance6716 · 2021-12-17T02:57:44Z

/merge

ti-chi-bot · 2021-12-17T02:57:46Z

This pull request has been accepted and is ready to merge.

Commit hash: 022b4f1

lance6716 · 2021-12-17T03:13:21Z

/hold

ERROR 2027 (HY000) at line 1: Malformed packet

strange that I can't reproduce it locally

lance6716 · 2021-12-17T06:21:11Z

/unhold
/merge

ti-chi-bot · 2021-12-17T06:21:14Z

This pull request has been accepted and is ready to merge.

Commit hash: 757db12

lance6716 · 2021-12-17T06:51:24Z

/run-dm-integration-test

lance6716 · 2021-12-17T06:54:47Z

/run-integration-test

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2021-12-17T07:22:29Z

In response to a cherrypick label: new pull request created: #3934.

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3795) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3741) * relay(dm): use binlog name comparison (#3710) (#3712) * dm/load: fix concurrent call Loader.Status (#3459) (#3468) * cdc/sorter: make unified sorter cgroup aware (#3436) (#3439) * tz (ticdc): fix timezone error (#3887) (#3906) * pkg,cdc: do not use log package (#3902) (#3940) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3959) * http_*: add log for http api and refine the err handle logic (#2997) (#3307) * etcd_worker: batch etcd patch (#3277) (#3389) * http_api (ticdc): check --cert-allowed-cn before add server common name (#3628) (#3882) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3663) * owner: fix owner tick block http request (#3490) (#3530) * dm/syncer: use downstream PK/UK to generate DML (#3168) (#3256) * dep(dm): update go-mysql (#3914) (#3934) * dm/syncer: multiple rows use downstream schema (#3308) (#3953) * errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (#3995) * dm/worker: don't exit when failed to read checkpoint in relay (#3345) (#4005) * syncer(dm): use an early location to reset binlog and open safemode (#3860) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3978) * dm/scheduler: fix inconsistent of relay status (#3474) (#4009) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4016) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3783) * sink(ticdc): cherry pick sink bug fix to release 5.3 (#4083) * master(dm): clean and treat invalid load task (#4004) (#4145) * loader: fix wrong progress in query-status for loader (#4093) (#4143) close #3252 * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4028) * dm: load table structure from dump files (#3295) (#4163) * compactor: fix duplicate entry in safemode (#3432) (#3434) (#4088) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4111) close #4006 * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4104) * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * retry(dm): align with tidb latest error message (#4172) (#4254) close #4159, close #4246 * owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) (#3865) * redolog: add a precleanup process when s3 enable (#3525) (#3878) * ddl(dm): make skipped ddl pass `SplitDDL()` (#4176) (#4227) close #4173 * cdc/sink: remove Initialize method from the sink interface (#3682) (#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4123) close #3840 * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4099) close #4055 * cdc/sink: adjust kafka initialization logic (#3192) (#4162) * try fix conflicts. * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: sdojjy <sdojjy@qq.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

dep(dm): update go-mysql

7727afd

ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 16, 2021

lance6716 added the area/dm Issues or PRs related to DM. label Dec 16, 2021

ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 16, 2021

ti-chi-bot requested review from Ehco1996 and lichunzhu December 16, 2021 09:27

Ehco1996 approved these changes Dec 16, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 16, 2021

lichunzhu approved these changes Dec 16, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 16, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2021

Merge branch 'master' into update-go-mysql

17a2487

ti-chi-bot added 2 commits December 16, 2021 19:15

Merge branch 'master' into update-go-mysql

d9e4286

Merge branch 'master' into update-go-mysql

e280991

Merge branch 'master' into update-go-mysql

c832e5c

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021

lance6716 added 2 commits December 17, 2021 10:29

save work

5281cb7

Merge branch 'update-go-mysql' of github.com:lance6716/ticdc into upd…

5eada19

…ate-go-mysql

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2021

lance6716 added 2 commits December 17, 2021 10:57

go mod tidy

8682019

Merge branch 'update-go-mysql' of github.com:lance6716/ticdc into upd…

022b4f1

…ate-go-mysql

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2021

ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2021

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2021

update again

0cc9853

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2021

Merge branch 'master' into update-go-mysql

757db12

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2021

Merge branch 'master' into update-go-mysql

576cd34

ti-chi-bot merged commit 84acdbc into pingcap:master Dec 17, 2021

lance6716 added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Dec 17, 2021

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 17, 2021

This is an automated cherry-pick of pingcap#3914

adeeb3c

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Dec 17, 2021

dep(dm): update go-mysql (#3914) #3934

Merged

ti-chi-bot added a commit that referenced this pull request Dec 21, 2021

dep(dm): update go-mysql (#3914) (#3934)

daaa2f8

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021

dep(dm): update go-mysql (pingcap#3914)

4b70721

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022

dep(dm): update go-mysql (pingcap#3914) (pingcap#3934)

167d9c5

lance6716 deleted the update-go-mysql branch October 13, 2022 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dep(dm): update go-mysql #3914

dep(dm): update go-mysql #3914

lance6716 commented Dec 16, 2021 •

edited

Loading

ti-chi-bot commented Dec 16, 2021 •

edited

Loading

codecov-commenter commented Dec 16, 2021 •

edited

Loading

lance6716 commented Dec 16, 2021

lichunzhu commented Dec 16, 2021

ti-chi-bot commented Dec 16, 2021

lance6716 commented Dec 16, 2021

purelind commented Dec 16, 2021

lance6716 commented Dec 16, 2021 •

edited

Loading

lance6716 commented Dec 17, 2021

ti-chi-bot commented Dec 17, 2021

lance6716 commented Dec 17, 2021

lance6716 commented Dec 17, 2021

ti-chi-bot commented Dec 17, 2021

lance6716 commented Dec 17, 2021

lance6716 commented Dec 17, 2021

ti-chi-bot commented Dec 17, 2021

dep(dm): update go-mysql #3914

dep(dm): update go-mysql #3914

Conversation

lance6716 commented Dec 16, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 16, 2021 • edited Loading

codecov-commenter commented Dec 16, 2021 • edited Loading

Codecov Report

lance6716 commented Dec 16, 2021

lichunzhu commented Dec 16, 2021

ti-chi-bot commented Dec 16, 2021

lance6716 commented Dec 16, 2021

purelind commented Dec 16, 2021

lance6716 commented Dec 16, 2021 • edited Loading

lance6716 commented Dec 17, 2021

ti-chi-bot commented Dec 17, 2021

lance6716 commented Dec 17, 2021

lance6716 commented Dec 17, 2021

ti-chi-bot commented Dec 17, 2021

lance6716 commented Dec 17, 2021

lance6716 commented Dec 17, 2021

ti-chi-bot commented Dec 17, 2021

lance6716 commented Dec 16, 2021 •

edited

Loading

ti-chi-bot commented Dec 16, 2021 •

edited

Loading

codecov-commenter commented Dec 16, 2021 •

edited

Loading

lance6716 commented Dec 16, 2021 •

edited

Loading