Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just for run tests #392

Closed
wants to merge 47 commits into from
Closed

just for run tests #392

wants to merge 47 commits into from

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-cdc/cdc-ansible
  • Need to be included in the release note

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one closed this Mar 28, 2020
Merge remote-tracking branch 'pingcap/master' into fix_sorted
997b6dd 
# Conflicts:
#	cdc/puller/entry_sorter.go
@zier-one zier-one reopened this Mar 29, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-io
Copy link

Codecov Report

Merging #392 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #392   +/-   ##
===========================================
  Coverage   31.4240%   31.4240%           
===========================================
  Files            61         61           
  Lines          5744       5744           
===========================================
  Hits           1805       1805           
  Misses         3782       3782           
  Partials        157        157

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

amyangfei
amyangfei reviewed Mar 29, 2020
View reviewed changes
cdc/entry/mounter.go Outdated
var minChIndex int
for i := 0; i < workerNum; i++ {
if events[i] == nil {
events[i] = <-eventChs[i]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be block ?

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-all-tests

@zier-one
Copy link
Contributor Author

/run-kafka-tests

@zier-one zier-one closed this Apr 1, 2020
@zier-one zier-one deleted the fix_sorted branch April 10, 2020 05:13
amyangfei added a commit to amyangfei/tiflow that referenced this pull request May 19, 2022
@amyangfei
ci(engine): use gh-docker-logs to dump logs in github action (pingcap…
c16e9f0 
…#392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zier-one @codecov-io @amyangfei