Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc,regionspan(ticdc): more logs about eventfeed retry rate limit #4008

Merged
merged 5 commits into from
Dec 26, 2021
Merged

cdc,regionspan(ticdc): more logs about eventfeed retry rate limit #4008

merged 5 commits into from
Dec 26, 2021

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Add more logs to facilitate debug for #4006

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@overvenus
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit
7a15235 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. type/enhancement The issue or PR belongs to an enhancement. labels Dec 21, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 21, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • ben1009

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021
amyangfei
amyangfei reviewed Dec 22, 2021
View reviewed changes
cdc/kv/client.go Outdated
log.Info("EventFeed retry rate limited",
zap.Uint64("regionID", errInfo.singleRegionInfo.verID.GetID()),
zap.Uint64("ts", errInfo.singleRegionInfo.ts),
zap.Int64("tableID", errInfo.singleRegionInfo.span.TableID()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can log span info, besides table id has been stored in context, which can be used directly.

@overvenus
address comments
35105c6 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2021
@overvenus
log span
254404a 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
address comments
2bf51c6 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2021
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2bf51c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 26, 2021
@overvenus
Copy link
Member Author

/run-verify
/run-integration-test
/run-dm-integration-test

@overvenus
Copy link
Member Author

/run-integration-test
/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 43a599d into pingcap:master Dec 26, 2021
liuzix added a commit that referenced this pull request Dec 27, 2021
@liuzix
Revert "cdc,regionspan(ticdc): more logs about eventfeed retry rate l…
1446484 
…imit (#4008)"

This reverts commit 43a599d.
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2021
@overvenus
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit (pi…
06a2587 
…ngcap#4008)
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2021
@overvenus
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit (pi…
83d64b3 
…ngcap#4008)
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2021
@overvenus
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit (pi…
14c9b1e 
…ngcap#4008)
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2021
@overvenus
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit (pi…
deceb6f 
…ngcap#4008)
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2021
@overvenus
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit (pi…
60309b5 
…ngcap#4008)
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@overvenus @zhaoxinyu
cdc,regionspan(ticdc): more logs about eventfeed retry rate limit (pi…
7e213ca 
…ngcap#4008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben1009 ben1009 ben1009 approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-chi-bot @amyangfei @ben1009