Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL(ticdc): add more online DDL debug log #4237

Merged
merged 1 commit into from
Jan 6, 2022
Merged

DDL(ticdc): add more online DDL debug log #4237

merged 1 commit into from
Jan 6, 2022

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4066

What is changed and how it works?

add DDL job debug log before being skip

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2022
@maxshuang maxshuang added the area/ticdc Issues or PRs related to TiCDC. label Jan 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #4237 (3d3f9d0) into master (08da001) will increase coverage by 0.0397%.
The diff coverage is 52.0379%.

Flag Coverage Δ
cdc 58.6520% <57.6412%> (+0.0072%) ⬆️
dm 52.2619% <40.5451%> (+0.0073%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4237        +/-   ##
================================================
+ Coverage   55.1722%   55.2120%   +0.0397%     
================================================
  Files           485        491         +6     
  Lines         59829      60936      +1107     
================================================
+ Hits          33009      33644       +635     
- Misses        23484      23919       +435     
- Partials       3336       3373        +37     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@ti-chi-bot
Copy link
Member

@zhaoxinyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d3f9d0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@lance6716
Copy link
Contributor

/run-verify

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit 101d53f into pingcap:master Jan 6, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more online DDL debug log for testing
7 participants