Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4337

Merged
merged 5 commits into from
Jan 20, 2022
Merged

owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4337

merged 5 commits into from
Jan 20, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4262

What problem does this PR solve?

Issue Number: close #3329 close #3987

What is changed and how it works?

Before this optimization:
When errors occurred in a changefeed, a simple backoff is leveraged to restart a changefeed:
If there are three errors which occurred in two minutes, the changefeed stays in "error" state and won't be restarted imediately.

After this optimization:
We utilize an exponential backoff mechanism in the changefeed restart logic. The mechanism is elaborated as follows:

  1. When we need to restart a changefeed in "error" state, the restart interval is varying from an InitialInterval to a MaxInterval. And if the duration since backoff start exceed the MaxElapsedTime, the changefeed will be switched to "failed" state and will not be restarted until it is manually resumed.
  2. If the changefeed was running normally in a period of time and it encounters error at present, we can reset the backoff and let the restart interval vary from the InitialInterval.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Add exponential backoff mechanism for restarting a changefeed.

@zhaoxinyu @ti-chi-bot
This is an automated cherry-pick of pingcap#4262
8f755fe 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved area/ticdc Issues or PRs related to TiCDC. labels Jan 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 14, 2022
Merged
@ti-chi-bot ti-chi-bot added component/owner Owner component. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jan 14, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 14, 2022
@overvenus overvenus added this to the v5.1.4 milestone Jan 17, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 19, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2022
@zhaoxinyu
Copy link
Contributor

/run-unit-test

@zhaoxinyu
Copy link
Contributor

/run-leak-test

2 similar comments
@zhaoxinyu
Copy link
Contributor

/run-leak-test

@zhaoxinyu
Copy link
Contributor

/run-leak-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test

2 similar comments
@zhaoxinyu
Copy link
Contributor

/run-integration-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 265b523

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@overvenus
Copy link
Member

/run-all-tests

@overvenus
Copy link
Member

/run-unit-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2022
@zhaoxinyu
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

1 similar comment
@zhaoxinyu
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

3 similar comments
@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit b597887 into pingcap:release-5.1 Jan 20, 2022
@zhaoxinyu zhaoxinyu mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zhaoxinyu zhaoxinyu

Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/owner Owner component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @zhaoxinyu @overvenus @VelocityLight