Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana(dm): fix grafana expr (#4405) #4462

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4405

What problem does this PR solve?

Issue Number: close #4404

What is changed and how it works?

use right expr

  • fix standard's lag lable not show
    stander lag label

  • fix binlog file gap between master and syncer
    截屏2022-01-19 下午3 04 15

  • fix binlog file gap between relay and syncer
    截屏2022-01-19 下午3 01 32

  • fix binlog file gap between master and relay
    截屏2022-01-19 下午3 05 00

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Jan 25, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@c13ec95). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #4462   +/-   ##
================================================
  Coverage               ?   55.2046%           
================================================
  Files                  ?        219           
  Lines                  ?      23335           
  Branches               ?          0           
================================================
  Hits                   ?      12882           
  Misses                 ?       9152           
  Partials               ?       1301           

@overvenus overvenus added this to the v5.3.1 milestone Jan 25, 2022
@lance6716
Copy link
Contributor

/assign @nongfushanquan

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b893ca3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@lance6716
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 6511ab0 into pingcap:release-5.3 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants